EnvGap
Wrong DLLExport declaration for static builds
envgap__zeux__pugixml-359
01 / FAILURE SIGNATURE
As reported upstream
No identifying execution failure has been captured.
Not a benchmark task.
- The project already builds and runs before the fix, so there is nothing to repair.
02 / ENVIRONMENT RECIPE
- Base commit
23ca940487565e1216e045b152b44264f9387024- Manifest
CMakeLists.txt- Reproduce
Awaiting issue-specific recipe- Run under trace
Awaiting a meaningful runtime command
03 / ORIGINAL ISSUE TEXT
zeux/pugixml #359 · read the original issue
Hi, I'm building your library as a static one, but I noticed all of your APIs are declared as `dllexport` which actually is not required ( see https://github.com/zeux/pugixml/blob/master/CMakeLists.txt#L105 ). I think you need to patch that line to something like `$<$<CXX_COMPILER_ID:MSVC>:PUGIXML_API=__fastcall>)`. Any better suggestion is welcome, as long as the library does not export when built statically :) Thank you in advance! //EDIT: I did try a personal patch by removing entirely that block and it works just fine as well. Using MSVC latest with `CMAKE_MSVC_RUNTIME_LIBRARY=MultiThreaded`
04 / LABELS
Labels from the report text only; not yet run
No supported category has been assigned.
Label rules and the text that matched
[]