← All tasks
javascripttesting-library/react-testing-library #883Not a task: not reproduced

When I install "@testing-library/react": "^11.2.5" in an existing project with tslint, I get missing kcd-scripts warning

envgap__testing-library__react-testing-library-883

01 / FAILURE SIGNATURE

As reported upstream

<!-- Please provide the full error message/screenshots/anything -->
Not a benchmark task.
  • In a clean container the reported failure did not reproduce, or the known fix did not make the project run.

02 / ENVIRONMENT RECIPE

Base commit
a241cb8a417135a529acb5504c83c0889080b8c2
Manifest
package.json
Reproduce
Awaiting issue-specific recipe
Run under trace
Awaiting a meaningful runtime command

03 / ORIGINAL ISSUE TEXT

testing-library/react-testing-library #883 · read the original issue
<!--



* Please fill out this template with all the relevant information so we can

  understand what's going on and fix the issue. We appreciate bugs filed and PRs

  submitted!



* If your issue is regarding one of the query APIs (`getByText`,

  `getByLabelText`, etc), then please file it on the `dom-testing-library`

  repository instead. If you file it here it will be closed. Thanks :)



* Please make sure that you are familiar with and follow the Code of Conduct for

  this project (found in the CODE_OF_CONDUCT.md file).



We'll probably ask you to submit the fix (after giving some direction). If

you've never done that before, that's great! Check this free short video

tutorial to learn how: http://kcd.im/pull-request



-->



- `@testing-library/react`: 11.2.5

- Testing Framework and version: jest at 26.6.3

  <!-- are you using jest, mocha, puppeteer, ava? And what version? -->

- DOM Environment: jsdom at 11.12.0

  <!-- If you're using jsdom (the default with jest), what version? Otherwise, what browser and version are you running tests in? -->



<!--

Keep in mind that if you're using a version of node we don't support that

could also be an issue. Check our package.json file "engines" config for the

supported version.



Also keep in mind that if you're using a version of react we don't support

that could be an issue. Check our package.json file "peerDependencies" config

for the supported version.

-->



### What you did:



install "@testing-library/react": "^11.2.5" via adding directly in package.json and `lerna bootstrap`.



### What happened:



> Cannot read file '.../node_modules/@testing-library/react/node_modules/kcd-scripts/shared-tsconfig.json'.



<!-- Please provide the full error message/screenshots/anything -->



### Problem description:



A dependency of react-testing-library is not being installed. In react-testing-library's package.json:



```json

 "eslintConfig": {

    "extends": "./node_modules/kcd-scripts/eslint.js",

```



So my editor now requires the existance of that eslint.js file.



### Suggested solution:



Add the missing kcd-scripts in dependencies of react-testing-library.



When I install `kcd-scripts` alongside `@testing-library/react` in my package devDependencies (and restart TS server in vs code), then the error goes away. But I would expect that the expected behaviour is to just install `@testing-library/react` and not get the error in the first place 🙂

Continue on GitHub ↗

04 / LABELS

Labels from the report text only; not yet run

No supported category has been assigned.

Label rules and the text that matched
[]