← All tasks
javascripttesting-library/react-testing-library #616Not a task: not reproduced

Dependancy on @testing-library/dom at ^7.0.2 causes failed installs on node less than 10.18

envgap__testing-library__react-testing-library-616

01 / FAILURE SIGNATURE

As reported upstream

error @testing-library/dom@7.0.2: The engine "node" is incompatible with this module. Expected version ">=10.18". Got "10.16.3"
Not a benchmark task.
  • In a clean container the reported failure did not reproduce, or the known fix did not make the project run.

02 / ENVIRONMENT RECIPE

Base commit
3bc13d94c05df06ae4cff5bf98ac1fd0cddb4783
Manifest
package.json
Reproduce
Awaiting issue-specific recipe
Run under trace
Awaiting a meaningful runtime command

03 / ORIGINAL ISSUE TEXT

testing-library/react-testing-library #616 · read the original issue
<!--



* Please fill out this template with all the relevant information so we can

  understand what's going on and fix the issue. We appreciate bugs filed and PRs

  submitted!



* If your issue is regarding one of the query APIs (`getByText`,

  `getByLabelText`, etc), then please file it on the `dom-testing-library`

  repository instead. If you file it here it will be closed. Thanks :)



* Please make sure that you are familiar with and follow the Code of Conduct for

  this project (found in the CODE_OF_CONDUCT.md file).



We'll probably ask you to submit the fix (after giving some direction). If

you've never done that before, that's great! Check this free short video

tutorial to learn how: http://kcd.im/pull-request



-->



- `@testing-library/react` version: 10.0.1

- `react` version:  16.13.0

- `node` version: 10.16.3

- `npm` (or `yarn`) version:  yarn v1.17.3



### Relevant code or config:

```

"@testing-library/dom@^7.0.2":

  version "7.0.2"

  resolved "https://registry.yarnpkg.com/@testing-library/dom/-/dom-7.0.2.tgz#9edc922dfe2644a3f0ff70f256d8c78a525b88c3"

  integrity sha512-5pqMlPaBC/5bvvFtuNTTcB4/Vg8NjZfs11LQQc08JhpMfx82W85nVw3re4D92A/C5O8zDkxPxyYPWNp8PtnQ/w==

  dependencies:

    "@babel/runtime" "^7.8.4"

    "@types/testing-library__dom" "^6.12.1"

    aria-query "^4.0.2"

    dom-accessibility-api "^0.3.0"

    pretty-format "^25.1.0"



"@testing-library/react@10.0.1":

  version "10.0.1"

  resolved "https://registry.yarnpkg.com/@testing-library/react/-/react-10.0.1.tgz#4f5e2a8836257c5bd3df640b21d7bea5a0d83ead"

  integrity sha512-sMHWud2dcymOzq2AhEniICSijEwKeTiBX+K0y36FYNY7wH2t0SIP1o732Bf5dDY0jYoMC2hj2UJSVpZC/rDsWg==

  dependencies:

    "@babel/runtime" "^7.8.7"

    "@testing-library/dom" "^7.0.2"

    "@types/testing-library__react" "^9.1.3"

```



<!--

If this is an issue with documentation, please file an issue on the docs repo:

https://github.com/alexkrolick/testing-library-docs

-->



### What you did:



<!-- What you were doing -->



### What happened:

Error message:

```

error @testing-library/dom@7.0.2: The engine "node" is incompatible with this module. Expected version ">=10.18". Got "10.16.3"

```



<!-- Please provide the full error message/screenshots/anything -->



### Reproduction:



<!--

If possible, please create a repository that reproduces the issue with the

minimal amount of code possible.



Template repo: https://github.com/alexkrolick/dom-testing-library-template



Or if you can, try to reproduce the issue in a Codesandbox. You can fork the one

here: https://codesandbox.io/s/5z6x4r7n0p

-->



### Problem description:

Yarn install is failing on node versions less the 10.18. This was fixed in @testing-library/react in version 10.0.1, and in @testing-library/dom in version 7.0.3. However, @testing-library/react requires @testing-library/dom at version ^7.0.2. Thus if @testing-library/dom is pinned at v7.0.2 in yarn.lock, yarn install still fails for node less than version 10.18.



This is an issue since AWS CodeBuild still runs on node v10.16



<!-- Please describe why the current behavior is a problem -->



### Suggested solution:

Require @testing-library/dom at version 7.0.3 or higher.

<!--

It's ok if you don't have a suggested solution, but it really helps if you could

do a little digging to come up with some suggestion of how to improve things.

-->

Continue on GitHub ↗

04 / LABELS

Labels from the report text only; not yet run

No supported category has been assigned.

Label rules and the text that matched
[]