Typings for v13.0.0 are broken
envgap__testing-library__react-testing-library-1039
01 / FAILURE SIGNATURE
As reported upstream
No identifying execution failure has been captured.
Not a benchmark task.
- In a clean container the reported failure did not reproduce, or the known fix did not make the project run.
02 / ENVIRONMENT RECIPE
- Base commit
93bc2c8afc8a7988ef9b4f5cb7f4101a2400735d- Manifest
package.json- Reproduce
Awaiting issue-specific recipe- Run under trace
Awaiting a meaningful runtime command
03 / ORIGINAL ISSUE TEXT
testing-library/react-testing-library #1039 · read the original issue
<!--
* Please fill out this template with all the relevant information so we can
understand what's going on and fix the issue. We appreciate bugs filed and PRs
submitted!
* If your issue is regarding one of the query APIs (`getByText`,
`getByLabelText`, etc), then please file it on the `dom-testing-library`
repository instead. If you file it here it will be closed. Thanks :)
* Please make sure that you are familiar with and follow the Code of Conduct for
this project (found in the CODE_OF_CONDUCT.md file).
We'll probably ask you to submit the fix (after giving some direction). If
you've never done that before, that's great! Check this free short video
tutorial to learn how: http://kcd.im/pull-request
-->
- `@testing-library/react` version: ^13.0.0
- Testing Framework and version: N/A
<!-- are you using jest, mocha, puppeteer, ava? And what version? -->
- DOM Environment: N/A
<!-- If you're using jsdom (the default with jest), what version? Otherwise, what browser and version are you running tests in? -->
<!--
Keep in mind that if you're using a version of node we don't support that
could also be an issue. Check our package.json file "engines" config for the
supported version.
Also keep in mind that if you're using a version of react we don't support
that could be an issue. Check our package.json file "peerDependencies" config
for the supported version.
-->
### Relevant code or config:
```json
{
"dependencies": {
"react": "^18.0.0",
"react-dom": "^18.0.0",
},
"devDependencies": {
"@testing-library/react": "^13.0.0",
"@types/react": "^18.0.1",
"@types/react-dom": "^18.0.0",
}
}
```
### Problem description:
<!-- Please describe why the current behavior is a problem -->
I have installed the above config and then ran `yarn` and the version that yarn picks for the `@types/react-dom` package for `@testing-libary/react` is `v17.X.Y` because it is specified as `*` in your config, which breaks the use of `React.Fragment` since in react 18 the `{}` was added to the type of fragment. This also breaks `React.ReactPortal` typings.
### Suggested solution:
Specify `^18.0.0` as the typings version.04 / LABELS
Labels from the report text only; not yet run
No supported category has been assigned.
Label rules and the text that matched
[]