javascripttesting-library/jest-dom #123Not a task: not reproduced

Make it so the TypeScript definitions work automatically without config

envgap__testing-library__jest-dom-123

Original GitHub issue ↗Dated source checkout ↗Opened 2019-08-15

01 / FAILURE SIGNATURE

As reported upstream

No identifying execution failure has been captured.

Not a benchmark task.

In a clean container the reported failure did not reproduce, or the known fix did not make the project run.

02 / ENVIRONMENT RECIPE

Base commit: d13bb902180828b2c0c464db43ad1619a383ece7
Manifest: package.json
Reproduce: Awaiting issue-specific recipe
Run under trace: Awaiting a meaningful runtime command

03 / ORIGINAL ISSUE TEXT

testing-library/jest-dom #123 · read the original issue

If we follow the path we took in [React Testing Library](https://github.com/testing-library/react-testing-library/pull/437) then that'll mean that people wont have to do anything [fancy](https://github.com/testing-library/jest-dom/issues/45#issuecomment-459651274) to make the typings/autocomplete show up which would be rad.



Specifically:



1. Add `testing-library__jest-dom` to `DefinitelyTyped`

2. Add `@types/testing-library__jest-dom` to `@testing-library/jest-dom` `dependencies`



I just tested it locally and that appears to work. If I have it in my node_modules then it just works™️



Anyone up for this?

Continue on GitHub ↗

04 / LABELS

Labels from the report text only; not yet run

No supported category has been assigned.

Label rules and the text that matched

[]