← All tasks
javascriptsindresorhus/execa #1097Not a task: already works

Node.js engine version in package.json is not up-to-date

envgap__sindresorhus__execa-1097

01 / FAILURE SIGNATURE

As reported upstream

No identifying execution failure has been captured.
Not a benchmark task.
  • The project already builds and runs before the fix, so there is nothing to repair.

02 / ENVIRONMENT RECIPE

Base commit
b959030b5acacf10d2908fbe261670f7af46e355
Manifest
package.json
Reproduce
Awaiting issue-specific recipe
Run under trace
Awaiting a meaningful runtime command

03 / ORIGINAL ISSUE TEXT

sindresorhus/execa #1097 · read the original issue
The release logs for [Execa 9.0.0](https://github.com/sindresorhus/execa/releases/tag/v9.0.0) state the following Node.js version support:



> Dropped support for Node.js version <18.19.0 and 20.0.0 - 20.4.0. (https://github.com/sindresorhus/execa/commit/834e3726f0c7b7f23827b6e09b69b66dedbddd47)



But in the current `package.json` it only requires:



https://github.com/sindresorhus/execa/blob/b959030b5acacf10d2908fbe261670f7af46e355/package.json#L19-L21



Is this intentional, or could the engine version be updated to:



```json

{

    "engines": {

        "node": "^18.19 || >20.4.0"

    }

}

```



This range should only match the following Node.js versions:



```

18.19.0, 18.19.1, 18.20.0, 18.20.1, 18.20.2, 18.20.3, 20.10.0, 20.11.0, 20.11.1, 20.12.0, 20.12.1, 20.12.2, 20.13.0, 20.13.1, 20.5.0, 20.5.1, 20.6.0, 20.6.1, 20.7.0, 20.8.0, 20.8.1, 20.9.0, 21.0.0, 21.1.0, 21.2.0, 21.3.0, 21.4.0, 21.5.0, 21.6.0, 21.6.1, 21.6.2, 21.7.0, 21.7.1, 21.7.2, 21.7.3, 22.0.0, 22.1.0, 22.2.0

```



I can contribute a Pull Request for this if you think it would be a good change. The reason I'm interested in this that I'm trying to follow the minimum supported Node.js version in [lint-staged](https://github.com/lint-staged/lint-staged) and usually it's up to the direct dependencies like `execa`. I have this simple script in the repo which prints out the all the engine versions, but it feels like `execa` is not correct at the moment: https://github.com/lint-staged/lint-staged/blob/master/scripts/list-dependency-node-versions.js
Continue on GitHub ↗

04 / LABELS

Labels from the report text only; not yet run

No supported category has been assigned.

Label rules and the text that matched
[]