← All tasks
pythonplotly/plotly.py #5680Not a task: already works

[chore] Add CI step to check that Python codegen files are up to date

envgap__plotly__plotly.py-5680

01 / FAILURE SIGNATURE

As reported upstream

No identifying execution failure has been captured.
Not a benchmark task.
  • The project already builds and runs before the fix, so there is nothing to repair.

02 / ENVIRONMENT RECIPE

Base commit
623abd8a2b1f1125990761389b37ce08f2900d41
Manifest
pyproject.toml
Reproduce
Awaiting issue-specific recipe
Run under trace
Awaiting a meaningful runtime command

03 / ORIGINAL ISSUE TEXT

plotly/plotly.py #5680 · read the original issue
Currently there's no check in the CI to verify that the files generated by the codegen script (which are the contents of `plotly/graph_objs/`) are up-to-date after the source files used in the codegen process are changed (primarily the files in `codegen/` itself, but for example `basevalidators.py` is also used).

This means that the CI can be green even if the generated files are out of date. This happened recently with https://github.com/plotly/plotly.py/pull/5673 resulting in the follow-up PR https://github.com/plotly/plotly.py/pull/5679.

We should add a CI job that runs the codegen and then fails if the generated files do not match what's committed in the repo.
Continue on GitHub ↗

04 / LABELS

Labels from the report text only; not yet run

No supported category has been assigned.

Label rules and the text that matched
[]