← All tasks
javascriptpillarjs/finalhandler #87Not a task: already works

`engines.node` suggests support for Node.js `>= 0.8`, but #80 broke with Node.js v14 and earlier

envgap__pillarjs__finalhandler-87

01 / FAILURE SIGNATURE

As reported upstream

No identifying execution failure has been captured.
Not a benchmark task.
  • The project already builds and runs before the fix, so there is nothing to repair.

02 / ENVIRONMENT RECIPE

Base commit
0919cb8ec25943736a38f29f308b4ee0c1371e20
Manifest
package.json
Reproduce
Awaiting issue-specific recipe
Run under trace
Awaiting a meaningful runtime command

03 / ORIGINAL ISSUE TEXT

pillarjs/finalhandler #87 · read the original issue
finalhandler@2.1.0 broke usage with Node.js v14 and earlier: #80 uses String.prototype.replaceAll, but this isn't supported in Node.js v14 (https://node.green/#ES2021-features--String-prototype-replaceAll).

The `engines.node` in package.json suggests that Node.js `>=0.8` is supported:
https://github.com/pillarjs/finalhandler/blob/v2.1.0/package.json#L33-L35

Of course, ci.yml only tests with Node.js v18 and later.

For *my* usage, I'm totally if `finalhandler` v2 only supports Node.js v18 and later. If so, it would be helpful to update `engines.node` in package.json, or just remove it.

Thanks.
Continue on GitHub ↗

04 / LABELS

Labels from the report text only; not yet run

No supported category has been assigned.

Label rules and the text that matched
[]