← All tasks
javaoracle/opengrok #4170Not a task: not reproduced

upgrade to jflex 1.9.1 and remove the workaround for lex scanners limits

envgap__oracle__opengrok-4170

01 / FAILURE SIGNATURE

As reported upstream

No identifying execution failure has been captured.
Not a benchmark task.
  • In a clean container the reported failure did not reproduce, or the known fix did not make the project run.

02 / ENVIRONMENT RECIPE

Base commit
f8a4c2e475375863601d926c62ef78274359a438
Manifest
pom.xml
Reproduce
Awaiting issue-specific recipe
Run under trace
Awaiting a meaningful runtime command

03 / ORIGINAL ISSUE TEXT

oracle/opengrok #4170 · read the original issue
jflex 1.9.0 is out and

https://github.com/jflex-de/jflex/issues/203

got fixed and jflex now introduces:

(https://github.com/jflex-de/jflex/issues/197 https://github.com/jflex-de/jflex/pull/1045 )

```

%token_size_limit (<identifier>|<number>)

```

which makes the workaround of manually patching generated lexical scanner obsolete, 

though I see @vladak removed it ?!?!?

https://github.com/oracle/opengrok/commit/d051e170ebfdcd5eaca944e0de2228fb2030f164

(I don't see 1.8 fixes it ... )

so it needs to be set where applicable so OpenGrok is in sync with lucene limits and their tokenizers



also https://github.com/jflex-de/jflex/issues/542 is fixed so https://github.com/oracle/opengrok/blob/master/pom.xml#L348

can be cleaned up



Continue on GitHub ↗

04 / LABELS

Labels from the report text only; not yet run

No supported category has been assigned.

Label rules and the text that matched
[]