← All tasks
pythonopencv/opencv-python #830Not a task: not reproduced

config: CMAKE_ARGS already supported by scikit-build

envgap__opencv__opencv-python-830

01 / FAILURE SIGNATURE

As reported upstream

The setup.py in OpenCV-Python manually checks for `CMAKE_ARGS`, and places that in the `cmake_args=` setup keyword. Scikit-build itself does this, and also does some post-processing on CMAKE_ARGS that is missing here, including stripping `CMAKE_INSTALL_PREFIX`, which cannot be set by projects. The recent (a few hours ago) 0.17.0 release of scikit-build now produces an error if it detects CMAKE_INSTALL_PREFIX in `cmake_args=` (since it should not be passed in), but it ignores CMAKE_ARGS (since that get set lots of places like Conda).
Not a benchmark task.
  • In a clean container the reported failure did not reproduce, or the known fix did not make the project run.

02 / ENVIRONMENT RECIPE

Base commit
0ec125d407cf3f68966f41d68cb052f532f7196e
Manifest
pyproject.toml
Reproduce
Awaiting issue-specific recipe
Run under trace
Awaiting a meaningful runtime command

03 / ORIGINAL ISSUE TEXT

opencv/opencv-python #830 · read the original issue
The setup.py in OpenCV-Python manually checks for `CMAKE_ARGS`, and places that in the `cmake_args=` setup keyword. Scikit-build itself does this, and also does some post-processing on CMAKE_ARGS that is missing here, including stripping `CMAKE_INSTALL_PREFIX`, which cannot be set by projects. The recent (a few hours ago) 0.17.0 release of scikit-build now produces an error if it detects CMAKE_INSTALL_PREFIX in `cmake_args=` (since it should not be passed in), but it ignores CMAKE_ARGS (since that get set lots of places like Conda).



The ideal fix would be to require scikit-build 0.14+, another fix would be to duplicate the filtering code in scikit-build: https://github.com/scikit-build/scikit-build/blob/6df6d571ba5c7be03729dd6b4d5e543c8aaae781/skbuild/setuptools_wrap.py#L545.



Seen in https://github.com/pyodide/pyodide/issues/3753. That was easy to fix, but it's likely going to hit (at least) conda builds.



##### Issue submission checklist



 - [x] This is not a generic OpenCV usage question (looking for help for coding, other usage questions, homework etc.)

   <!--



   Use Q&A forums such as https://answers.opencv.org/questions/ and https://stackoverflow.com/ and other communities

   to discuss problems. Tickets without real issue statements related to this build toolchain will be closed.



   -->

 - [x] I have read the README of this repository and understand that this repository provides only an automated build toolchain for OpenCV Python packages (there is no actual OpenCV code here)

   <!--



   If you have some OpenCV bug report which needs to fixed in the C++ code, 

   please report issue to the OpenCV repository: 



   https://github.com/opencv/opencv/issues



   See also:



   * OpenCV documentation: https://docs.opencv.org

   * OpenCV FAQ page: https://github.com/opencv/opencv/wiki/FAQ

   * OpenCV forum: https://answers.opencv.org

   * Stack Overflow branch: https://stackoverflow.com/questions/tagged/opencv



   -->

 - [x] The issue is related to the build scripts in this repository, to the pre-built binaries or is a feature request (such as "please enable this additional dependency")

 - [x] I'm using the latest version of ``opencv-python``

Continue on GitHub ↗

04 / LABELS

Labels from the report text only; not yet run

No supported category has been assigned.

Label rules and the text that matched
[]