cppopenMVG/openMVG #1265Not a task: already works

FindFlann.cmake missing linker flag -llz4.

envgap__openMVG__openMVG-1265

Original GitHub issue ↗Dated source checkout ↗Opened 2018-03-28

01 / FAILURE SIGNATURE

As reported upstream

No identifying execution failure has been captured.

Not a benchmark task.

The project already builds and runs before the fix, so there is nothing to repair.

02 / ENVIRONMENT RECIPE

Base commit: e1bbfe801986cd7171f36443a1573b0f69f3702d
Manifest: src/CMakeLists.txt
Reproduce: Awaiting issue-specific recipe
Run under trace: Awaiting a meaningful runtime command

03 / ORIGINAL ISSUE TEXT

openMVG/openMVG #1265 · read the original issue

I stumble on a problem with [src/cmakeFindModules/FindFlann.cmake](https://github.com/openMVG/openMVG/blob/db92617fea420363abcbad1cb3773706f75012ad/src/cmakeFindModules/FindFlann.cmake)

It uses custom, cmake script, where [openMVG/src/third_party/flann/cmake/FindFlann.cmake](https://github.com/openMVG/openMVG/blob/db92617fea420363abcbad1cb3773706f75012ad/src/third_party/flann/cmake/FindFlann.cmake) uses `pkg-config`.

On my system, `flann` requires `-llz4` flag (flann:v1.9.1) which gets included when using `pkg-config` based `FindFlann.cmake` (the `FLANN_DEFINITIONS` variable).

Could we combine those two, first import `pkg-config` and check if it finds `flann` and if not resolve to `find_path()`

_refers to: openmvg#branch=develop_



_Also `fast` is missing from `target_link_libraries` in `software/VO`_

_Also `lemon` insted of `emon` is used in `software/colorHarmonize/CMakeLists.txt`_

Continue on GitHub ↗

04 / LABELS

Labels from the report text only; not yet run

No supported category has been assigned.

Label rules and the text that matched

[]