← All tasks
javascriptnodemailer/nodemailer #1853Not a task: already works

v10 types have differences when using exactOptionalPropertyTypes

envgap__nodemailer__nodemailer-1853

01 / FAILURE SIGNATURE

As reported upstream

No identifying execution failure has been captured.
Not a benchmark task.
  • The project already builds and runs before the fix, so there is nothing to repair.

02 / ENVIRONMENT RECIPE

Base commit
81e64eaee70aabf867afef88d3733556c9fcc1cc
Manifest
package.json
Reproduce
Awaiting issue-specific recipe
Run under trace
Awaiting a meaningful runtime command

03 / ORIGINAL ISSUE TEXT

nodemailer/nodemailer #1853 · read the original issue
We noticed this with `MailComposerOptions` which has all the optional properties specified using just `?`. It would also be helpful to replicate the old type behaviour which allows passing undefined in explicitly. For example:

```ts
new MailComposer({
      from: email.from_email,
      to: email.to,
      cc: email.cc,
      replyTo: email.reply_to, // email.reply_to is string | undefined
});
```

The types would need to change from e.g. `replyTo?: MimeNodeAddressInput;` to `replyTo?: MimeNodeAddressInput | undefined;`

I'd be happy to pull together a PR for this.
Continue on GitHub ↗

04 / LABELS

Labels from the report text only; not yet run

No supported category has been assigned.

Label rules and the text that matched
[]