pythonmaxmind/MaxMind-DB-Reader-python #154Not a task: already works

setuptools is (incorrectly?) listed as a production dependency in pyproject.toml

envgap__maxmind__MaxMind-DB-Reader-python-154

Original GitHub issue ↗Dated source checkout ↗Opened 2024-03-18

01 / FAILURE SIGNATURE

As reported upstream

No identifying execution failure has been captured.

Not a benchmark task.

The project already builds and runs before the fix, so there is nothing to repair.

02 / ENVIRONMENT RECIPE

Base commit: ee8e7f912aacf14af1a2a10751801168a21c9c7f
Manifest: pyproject.toml
Reproduce: Awaiting issue-specific recipe
Run under trace: Awaiting a meaningful runtime command

03 / ORIGINAL ISSUE TEXT

maxmind/MaxMind-DB-Reader-python #154 · read the original issue

Hello!



The `[dependencies]` section of `pyproject.toml` [lists](https://github.com/maxmind/MaxMind-DB-Reader-python/blob/23738928bb88dab1891fe34a5ee68a6009951802/pyproject.toml#L13) `setuptools>=68.2.2`. I think this is unnecessary; it's not required in the production code, only to build it. As it is, this means that production builds must ship (or provide its own stub of) setuptools, even though it will never be used in a production deployment.



I think this should be as simple as moving the version constraint part of this dependency up to its entry in `requires` under `[build-system]`. I'd gladly open a PR for this because it seems like a trivial fix, but I do not know if there are reasons for how it currently is.



Thanks for the library!



L

Continue on GitHub ↗

04 / LABELS

Labels from the report text only; not yet run

No supported category has been assigned.

Label rules and the text that matched

[]