← All tasks
javascriptkelektiv/node.bcrypt.js #1001Not a task: already works

Support multiple platforms at once

envgap__kelektiv__node.bcrypt.js-1001

01 / FAILURE SIGNATURE

As reported upstream

No identifying execution failure has been captured.
Not a benchmark task.
  • The project already builds and runs before the fix, so there is nothing to repair.

02 / ENVIRONMENT RECIPE

Base commit
33043f50a4e13fd67140a3dce17079fd32ef0a77
Manifest
package.json
Reproduce
Awaiting issue-specific recipe
Run under trace
Awaiting a meaningful runtime command

03 / ORIGINAL ISSUE TEXT

kelektiv/node.bcrypt.js #1001 · read the original issue
In some situations it might be useful to have binaries for different platforms downloaded at once. For example, when using docker on Mac it's common to use npm on directly on Mac but actually run the code in the docker linux vm, which will fail due to incompatible binaries. It's possible to download for binaries for another platform by running for example `npm run install -- --update-binary --target_platform=linux --target_libc=glibc`, but since bcrypt uses the same file path regardless of platform/architecture this will replace the existing binary. I propose changing `module_path` or `module_name` to include `platform`, `arch`, and `libc`, like the `package_name` currently does. I can submit a PR for this if you're interested.



Related issues:

- https://github.com/mapbox/node-pre-gyp/issues/18

- https://github.com/TryGhost/node-sqlite3/issues/248

- https://github.com/kelektiv/node.bcrypt.js/issues/824









Continue on GitHub ↗

04 / LABELS

Labels from the report text only; not yet run

No supported category has been assigned.

Label rules and the text that matched
[]