cppjank-lang/jank #86Not a task: not reproduced

Reported build failure with double-conversion and openssl on macOS

envgap__jank-lang__jank-86

Original GitHub issue ↗Dated source checkout ↗Opened 2024-08-17

01 / FAILURE SIGNATURE

As reported upstream

jank/compiler+runtime/third-party/folly/folly/Conv.h:124:10: fatal error: 'double-conversion/double-conversion.h' file not found

Not a benchmark task.

In a clean container the reported failure did not reproduce, or the known fix did not make the project run.

02 / ENVIRONMENT RECIPE

Base commit: e774da6e3d029c884caefa5c27922b25713b24f7
Manifest: compiler+runtime/CMakeLists.txt
Reproduce: Awaiting issue-specific recipe
Run under trace: Awaiting a meaningful runtime command

03 / ORIGINAL ISSUE TEXT

jank-lang/jank #86 · read the original issue

A user in Slack reported macOS build failures for jank, after running `./bin/compile`:



```

jank/compiler+runtime/third-party/folly/folly/Conv.h:124:10: fatal error: 'double-conversion/double-conversion.h' file not found

jank/compiler+runtime/src/cpp/jank/util/sha256.cpp:3:10: fatal error: 'openssl/sha.h' file not found

```



The user had `double-conversion` and `openssl` installed via homebrew. I suspect that we need to find these packages via cmake. This wasn't a problem before, since we used vcpkg to build folly, but now that we build it as part of jank's compilation, we'll need to meet its dependencies.



I suspect this hasn't been an issue on Linux, since those headers are standard places. Homebrew puts them somewhere non-standard.



This should be a reasonably straight-forward CMake change for anyone on macOS.

Continue on GitHub ↗

04 / LABELS

Labels from the report text only; not yet run

No supported category has been assigned.

Label rules and the text that matched

[]