cppgoogle/snappy #190Not a task: already works

add a cmake option `MSVC_RUNTIME_LIBRARY`

envgap__google__snappy-190

Original GitHub issue ↗Dated source checkout ↗Opened 2024-09-13

01 / FAILURE SIGNATURE

As reported upstream

No identifying execution failure has been captured.

Not a benchmark task.

The project already builds and runs before the fix, so there is nothing to repair.

02 / ENVIRONMENT RECIPE

Base commit: 26aa88cbb235a35d4604d2dd5f5284566862de77
Manifest: CMakeLists.txt
Reproduce: Awaiting issue-specific recipe
Run under trace: Awaiting a meaningful runtime command

03 / ORIGINAL ISSUE TEXT

google/snappy #190 · read the original issue

`CMakelists.txt` Line 286:

```

if(BUILD_SHARED_LIBS)

  set_target_properties(snappy PROPERTIES WINDOWS_EXPORT_ALL_SYMBOLS ON)

endif(BUILD_SHARED_LIBS)

```

May I ask for an additional option `MSVC_RUNTIME_LIBRARY` here? When building static libs `CMAKE_CXX_FLAGS` should includes `/MTd`, instead of CMake's default value `/MDd`.

Continue on GitHub ↗

04 / LABELS

Labels from the report text only; not yet run

No supported category has been assigned.

Label rules and the text that matched

[]