cppgoogle/benchmark #1702Not a task: not reproduced

[FR] Enforce CMake to find PFM or fail when `BENCHMARK_ENABLE_LIBPFM` is `ON`

envgap__google__benchmark-1702

Original GitHub issue ↗Dated source checkout ↗Opened 2023-11-16

01 / FAILURE SIGNATURE

As reported upstream

No identifying execution failure has been captured.

Not a benchmark task.

In a clean container the reported failure did not reproduce, or the known fix did not make the project run.

02 / ENVIRONMENT RECIPE

Base commit: 54e4327190b6c06aeadc3186ed17566fd8da2a61
Manifest: CMakeLists.txt
Reproduce: Awaiting issue-specific recipe
Run under trace: Awaiting a meaningful runtime command

03 / ORIGINAL ISSUE TEXT

google/benchmark #1702 · read the original issue

Currently, setting `BENCHMARK_ENABLE_LIBPFM` to `ON` only *tries* to find `PFM`, but I think it should *find it or fail* since the user wants it.



https://github.com/google/benchmark/blob/93a96a26a6ba36894d7fa6f43513708c595ccb5f/CMakeLists.txt#L314-L316



Does the `find_package` simply need the `REQUIRED` keyword?

Continue on GitHub ↗

04 / LABELS

Labels from the report text only; not yet run

No supported category has been assigned.

Label rules and the text that matched

[]