javascriptexpressjs/body-parser #476Not a task: already works

Update iconv-lite to latest 0.6.3

envgap__expressjs__body-parser-476

Original GitHub issue ↗Dated source checkout ↗Opened 2022-11-30

01 / FAILURE SIGNATURE

As reported upstream

No identifying execution failure has been captured.

Not a benchmark task.

The project already builds and runs before the fix, so there is nothing to repair.

02 / ENVIRONMENT RECIPE

Base commit: a5daa07827d81fc40599b53476c19b99f617dc0e
Manifest: package.json
Reproduce: Awaiting issue-specific recipe
Run under trace: Awaiting a meaningful runtime command

03 / ORIGINAL ISSUE TEXT

expressjs/body-parser #476 · read the original issue

In a project I work we use body-parser and mysql2 as dependencies.

We are running a very common combination of prisma+mysql2 / expressjs+bodyparser in vercel, and every bundle kb is important in cold start lambda functions.



mysql2 depends on iconv-lite: 0.6.3 and body-parser depends on iconv-lite: 0.4.24



I think it can be upgraded in body-parser to have the same library and avoid code duplication. This would save around 600kb (~500kb of duplication + ~100kb of improved bundle size in 0.6.0).



Thank you for this great project!

Continue on GitHub ↗

04 / LABELS

Labels from the report text only; not yet run

No supported category has been assigned.

Label rules and the text that matched

[]