pythonexplosion/thinc #592Not a task: already works

Compatibility problem with murmurhash <1.0.2

envgap__explosion__thinc-592

Original GitHub issue ↗Dated source checkout ↗Opened 2022-02-17

01 / FAILURE SIGNATURE

As reported upstream

ImportError: cannot import name 'hash_unicode' from 'murmurhash' (/usr/lib/python3/dist-packages/murmurhash/__init__.py)

Not a benchmark task.

The project already builds and runs before the fix, so there is nothing to repair.

02 / ENVIRONMENT RECIPE

Base commit: 5bb7dac28ba22814639431a952d07f400846c5cf
Manifest: pyproject.toml
Reproduce: Awaiting issue-specific recipe
Run under trace: Awaiting a meaningful runtime command

03 / ORIGINAL ISSUE TEXT

explosion/thinc #592 · read the original issue

There is a compatibility issue using thinc with murmurhash <1.0.2. The necessary imports were introduced with version 1.0.2.



```File "/usr/lib/python3/dist-packages/thinc/layers/__init__.py", line 56, in <module>

   from .strings2arrays import strings2arrays

 File "/usr/lib/python3/dist-packages/thinc/layers/strings2arrays.py", line 2, in <module>

   from murmurhash import hash_unicode

ImportError: cannot import name 'hash_unicode' from 'murmurhash' (/usr/lib/python3/dist-packages/murmurhash/__init__.py)

```

From my point of view murmurhash should be pinned to >= 1.0.2 in the requirements.txt



Tested with versions:

thinc: 8.0.13

murmurhash: 1.0.1-2

Continue on GitHub ↗

04 / LABELS

Labels from the report text only; not yet run

No supported category has been assigned.

Label rules and the text that matched

[]