← All tasks
cppdiasurgical/DevilutionX #8537Not a task: not reproduced

Unable to compile under DOS since inclusion of mpqfs

envgap__diasurgical__DevilutionX-8537

01 / FAILURE SIGNATURE

As reported upstream

/home/srandista/Downloads/DevilutionX/build-dos/_deps/mpqfs-src/src/mpq_archive.c:391:20: error: implicit declaration of function 'fdopen'; did you mean 'fopen'? [-Wimplicit-function-declaration]
Not a benchmark task.
  • In a clean container the reported failure did not reproduce, or the known fix did not make the project run.

02 / ENVIRONMENT RECIPE

Base commit
35b8c54c9dfbf999afdfdabfb541eaa10a0861cf
Manifest
3rdParty/mpqfs/CMakeLists.txt
Reproduce
Awaiting issue-specific recipe
Run under trace
Awaiting a meaningful runtime command

03 / ORIGINAL ISSUE TEXT

diasurgical/DevilutionX #8537 · read the original issue
### Operating System

Other (please specify)

### DevilutionX version

Other (please specify version number)

### Describe

During the compilation of a code, where libmpq was replaced by mpqfs for DOS, I get following errors:

```/home/srandista/Downloads/DevilutionX/build-dos/_deps/mpqfs-src/src/mpq_archive.c: In function 'mpqfs_open_fd':
/home/srandista/Downloads/DevilutionX/build-dos/_deps/mpqfs-src/src/mpq_archive.c:391:20: error: implicit declaration of function 'fdopen'; did you mean 'fopen'? [-Wimplicit-function-declaration]
  391 |         FILE *fp = fdopen(fd, "rb");
      |                    ^~~~~~
      |                    fopen
/home/srandista/Downloads/DevilutionX/build-dos/_deps/mpqfs-src/src/mpq_archive.c:391:20: error: initialization of 'FILE *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
```

Commit before library replacing (e6f958be25ab76f6131d041ec05dac9c91fb1ba2) compiles just fine. Windows (even SDL1) builds are also unaffected.

### To Reproduce

Build latest source code for DOS with commands provided in Build from Source article on wiki.

### Expected Behavior

_No response_

### Additional context

_No response_
Continue on GitHub ↗

04 / LABELS

Labels from the report text only; not yet run

No supported category has been assigned.

Label rules and the text that matched
[]