← All tasks
javaapache/dubbo #11833Not a task: already works

dubbo-common 模块中的 json 相关依赖是否应该是 optional 的?

envgap__apache__dubbo-11833

01 / FAILURE SIGNATURE

As reported upstream

No identifying execution failure has been captured.
Not a benchmark task.
  • The project already builds and runs before the fix, so there is nothing to repair.

02 / ENVIRONMENT RECIPE

Base commit
0862819991cb03141d93f8bebc84541ca39de847
Manifest
dubbo-common/pom.xml
Reproduce
Awaiting issue-specific recipe
Run under trace
Awaiting a meaningful runtime command

03 / ORIGINAL ISSUE TEXT

apache/dubbo #11833 · read the original issue
```xml

<dependency>

    <groupId>com.alibaba</groupId>

    <artifactId>fastjson</artifactId>

    <scope>provided</scope>

</dependency>

```



```xml

<dependency>

    <groupId>com.google.code.gson</groupId>

    <artifactId>gson</artifactId>

    <scope>provided</scope>

</dependency>

```





这 2 个依赖从语义上来看,应该是 optional 的吧?

现在 scope 是 provider 的,如果应用程序中,两个 json 框架都没引入,虽然最终都会抛异常提醒用户进行 json 框架的引入

但是从语义上来说,可能改成 optional 的会不会更合适呢?
Continue on GitHub ↗

04 / LABELS

Labels from the report text only; not yet run

No supported category has been assigned.

Label rules and the text that matched
[]