← All tasks
javascriptalexindigo/asynckit #53Not a task: already works

Adding `sideEffects: false` to package.json

envgap__alexindigo__asynckit-53

01 / FAILURE SIGNATURE

As reported upstream

No identifying execution failure has been captured.
Not a benchmark task.
  • The project already builds and runs before the fix, so there is nothing to repair.

02 / ENVIRONMENT RECIPE

Base commit
583a75ed4fe41761b66416bb6e703ebb1f8963bf
Manifest
package.json
Reproduce
Awaiting issue-specific recipe
Run under trace
Awaiting a meaningful runtime command

03 / ORIGINAL ISSUE TEXT

alexindigo/asynckit #53 · read the original issue
Hello! :)

Would it make sense to add `sideEffects: false` to `package.json`? This can enable more tree-shaking, in some cases: https://github.com/webpack/webpack/blob/main/examples/side-effects/README.md

`axios`, which (indirectly) depends on this package, has already added this flag: https://github.com/axios/axios/pull/5025

(Also true for [node-combined-stream](https://github.com/felixge/node-combined-stream) )
Continue on GitHub ↗

04 / LABELS

Labels from the report text only; not yet run

No supported category has been assigned.

Label rules and the text that matched
[]