← All tasks
cppSFML/SFML #2389Not a task: not reproduced

Stop changing the default value of `BUILD_SHARED_LIBS`

envgap__SFML__SFML-2389

01 / FAILURE SIGNATURE

As reported upstream

No identifying execution failure has been captured.
Not a benchmark task.
  • In a clean container the reported failure did not reproduce, or the known fix did not make the project run.

02 / ENVIRONMENT RECIPE

Base commit
10bd1ffebac9908da8165ad63daf49446b52487c
Manifest
CMakeLists.txt
Reproduce
Awaiting issue-specific recipe
Run under trace
Awaiting a meaningful runtime command

03 / ORIGINAL ISSUE TEXT

SFML/SFML #2389 · read the original issue
[Here](https://github.com/SFML/SFML/blob/master/CMakeLists.txt#L47) we default to building shared libraries for most platforms. Not only is this unnecessary to specify, it actively causes lots of pain for Windows users who routinely struggle to understand how DLLs work. Such users would be better off if we stuck to the CMake default of static libraries so they didn't have to try so hard to get their programs building. We can achieve this by simply removing any reference to `BUILD_SHARED_LIBS` and letting it return to its default false-y state.



It's been discussed on the forums [here](https://en.sfml-dev.org/forums/index.php?topic=27996.msg175824#msg175824).



Are there any benefits to defaulting to shared libraries that I'm missing?
Continue on GitHub ↗

04 / LABELS

Labels from the report text only; not yet run

No supported category has been assigned.

Label rules and the text that matched
[]