← All tasks
pythonPyCQA/isort #2206Not a task: already works

Lots of new direct dependencies `[5.13]`

envgap__PyCQA__isort-2206

01 / FAILURE SIGNATURE

As reported upstream

No identifying execution failure has been captured.
Not a benchmark task.
  • The project already builds and runs before the fix, so there is nothing to repair.

02 / ENVIRONMENT RECIPE

Base commit
4be9850e1aa0d79f91eb5b626046289e7929290f
Manifest
pyproject.toml
Reproduce
Awaiting issue-specific recipe
Run under trace
Awaiting a meaningful runtime command

03 / ORIGINAL ISSUE TEXT

PyCQA/isort #2206 · read the original issue
Because these entries:

```toml

pipfile_deprecated_finder = ["pipreqs", "requirementslib", "pip-shims"]

requirements_deprecated_finder = ["pipreqs", "pip-api"]

```

were removed from `[tool.poetry.extras]` but the underlying deps kept in `[tool.poetry.dependencies]` in #2089, most "optional" deps are now installed by default.



From what I gather from [poetry](https://python-poetry.org/docs/pyproject/#extras), it doesn't make sense to have deps flagged `optional` if they're not tied to an extra.



```diff

 [[package]]

 name = "isort"

-version = "5.12.0"

+version = "5.13.0"

 description = "A Python utility / library to sort Python imports."

 optional = false

 python-versions = ">=3.8.0"

 files = [

-    {file = "isort-5.12.0-py3-none-any.whl", hash = "sha256:f84c2818376e66cf843d497486ea8fed8700b340f308f076c6fb1229dff318b6"},

-    {file = "isort-5.12.0.tar.gz", hash = "sha256:8bef7dde241278824a6d83f44a544709b065191b95b6e50894bdc722fcba0504"},

+    {file = "isort-5.13.0-py3-none-any.whl", hash = "sha256:15e0e937819b350bc256a7ae13bb25f4fe4f8871a0bc335b20c3627dba33f458"},

+    {file = "isort-5.13.0.tar.gz", hash = "sha256:d67f78c6a1715f224cca46b29d740037bdb6eea15323a133e897cda15876147b"},

 ]



+[package.dependencies]

+pip-api = "*"

+pipreqs = "*"

+requirementslib = "*"

+

 [package.extras]

-colors = ["colorama (>=0.4.3)"]

-pipfile-deprecated-finder = ["pip-shims (>=0.5.2)", "pipreqs", "requirementslib"]

+colors = ["colorama (>=0.4.6)"]

 plugins = ["setuptools"]

-requirements-deprecated-finder = ["pip-api", "pipreqs"]
Continue on GitHub ↗

04 / LABELS

Labels from the report text only; not yet run

No supported category has been assigned.

Label rules and the text that matched
[]