javascriptLizardByte/Sunshine #1900Not a task: not reproduced

[Nix] Include a package-lock.json in the repository

envgap__LizardByte__Sunshine-1900

Original GitHub issue ↗Dated source checkout ↗Opened 2023-12-09

01 / FAILURE SIGNATURE

As reported upstream

No identifying execution failure has been captured.

Not a benchmark task.

In a clean container the reported failure did not reproduce, or the known fix did not make the project run.

02 / ENVIRONMENT RECIPE

Base commit: 888a6bb0cbdab97afb3df712f85f19c09dccd367
Manifest: package.json
Reproduce: Awaiting issue-specific recipe
Run under trace: Awaiting a meaningful runtime command

03 / ORIGINAL ISSUE TEXT

LizardByte/Sunshine #1900 · read the original issue

Please consider taking the `package-lock.json` file out of gitignore. I understand that the package count is small enough where it doesn't really matter for most cases, but it's still generally standard practice to include it, and it will remove the need for Nix to include their own:

https://github.com/NixOS/nixpkgs/blob/592047fc9e4f7b74a4dc85d1b9f5243dfe4899e3/pkgs/servers/sunshine/default.nix#L65



The idea behind Nix is to have reproducible builds, so a package-lock is required to have a consistent build each time, and it's impossible to overwrite that without disabling sandboxing. So currently, Nix devs need to include their own package-lock for this project.

Continue on GitHub ↗

04 / LABELS

Labels from the report text only; not yet run

No supported category has been assigned.

Label rules and the text that matched

[]