EnvGap
Remove wine fork from codebase
envgap__LMMS__lmms-8076
01 / FAILURE SIGNATURE
As reported upstream
No identifying execution failure has been captured.
Not a benchmark task.
- In a clean container the reported failure did not reproduce, or the known fix did not make the project run.
02 / ENVIRONMENT RECIPE
- Base commit
807751dc4dce53583ecf4140b67a5dc343c789a7- Manifest
CMakeLists.txt- Reproduce
Awaiting issue-specific recipe- Run under trace
Awaiting a meaningful runtime command
03 / ORIGINAL ISSUE TEXT
LMMS/lmms #8076 · read the original issue
> The upstream fix was released in [Wine 10.14](https://gitlab.winehq.org/wine/wine/-/commit/1d1e5fb3e51b2acb0143e86c16463dfed1bc90aa) and can now be installed through the `winehq-devel` .deb package.
@messmerd This is great news! This won't fix local builds, so I'm curious what the timeline should be on removing the no-longer-needed parts... At a glance:
Remove this entire section:
* https://github.com/LMMS/lmms/blob/a1e30982b2bb7522d0cc43d11dd9d4329635e5be/plugins/VstBase/CMakeLists.txt#L50-L67
Remove `--winebuild \"${CUSTOM_WINEBUILD_EXECUTABLE}\"` from this:
* https://github.com/LMMS/lmms/blob/a1e30982b2bb7522d0cc43d11dd9d4329635e5be/plugins/VstBase/RemoteVstPlugin32.cmake#L38
... but this code will continue to work for local copies with other wine versions, so I'm unsure how soon we should do this.
Thoughts welcome.
_Originally posted by @tresf in https://github.com/LMMS/lmms/issues/7987#issuecomment-3372144579_
04 / LABELS
Labels from the report text only; not yet run
No supported category has been assigned.
Label rules and the text that matched
[]