cppKhronosGroup/glslang #3507Not a task: not reproduced

cmake: allow enabling of tests and install independently of whether the project is top level

envgap__KhronosGroup__glslang-3507

Original GitHub issue ↗Dated source checkout ↗Opened 2024-02-12

01 / FAILURE SIGNATURE

As reported upstream

No identifying execution failure has been captured.

Not a benchmark task.

In a clean container the reported failure did not reproduce, or the known fix did not make the project run.

02 / ENVIRONMENT RECIPE

Base commit: 47a02a987c4e6dc573dfca1b80e5e3eacf4e2ed8
Manifest: CMakeLists.txt
Reproduce: Awaiting issue-specific recipe
Run under trace: Awaiting a meaningful runtime command

03 / ORIGINAL ISSUE TEXT

KhronosGroup/glslang #3507 · read the original issue

Glslang tests and installs only if Glslang is the top-level project directory.

See https://github.com/KhronosGroup/glslang/blob/47a02a987c4e6dc573dfca1b80e5e3eacf4e2ed8/CMakeLists.txt#L307 



This makes the project non-composable.  It's also a regression from before where enclosing projects like Shaderc want to test Glslang's tests.



Ultimately, the disabling of tests caused us to miss the following problem

https://github.com/KhronosGroup/glslang/issues/3505 



(It seems to me it's an anti-pattern to overuse PROJECT_IS_TOP_LEVEL?)



cc: @juan-lunarg @arcady-lunarg

Continue on GitHub ↗

04 / LABELS

Labels from the report text only; not yet run

No supported category has been assigned.

Label rules and the text that matched

[]