cppKhronosGroup/Vulkan-Hpp #2104Not a task: already works

Tests fail when samples are disabled

envgap__KhronosGroup__Vulkan-Hpp-2104

Original GitHub issue ↗Dated source checkout ↗Opened 2025-03-17

01 / FAILURE SIGNATURE

As reported upstream

Vulkan-Hpp/tests/UniqueHandle/../../samples/utils/utils.hpp:21:10: fatal error: 'GLFW/glfw3.h' file not found

Not a benchmark task.

The project already builds and runs before the fix, so there is nothing to repair.

02 / ENVIRONMENT RECIPE

Base commit: f9c5bfde492e975a5d301e36fe8daa8eda6abcb3
Manifest: CMakeLists.txt
Reproduce: Awaiting issue-specific recipe
Run under trace: Awaiting a meaningful runtime command

03 / ORIGINAL ISSUE TEXT

KhronosGroup/Vulkan-Hpp #2104 · read the original issue

Building the tests without samples results in failure, as GLFW (among other things) will be missing:
```bash
Vulkan-Hpp/tests/UniqueHandle/../../samples/utils/utils.hpp:21:10: fatal error: 'GLFW/glfw3.h' file not found
   21 | #include <GLFW/glfw3.h>
```

Reproducible via:
```cmake
VULKAN_HPP_SAMPLES_BUILD OFF
VULKAN_HPP_TESTS_BUILD ON
VULKAN_HPP_TESTS_BUILD_ONLY_DYNAMIC ON
```

The tests for `UniqueHandle` require more targets to be available, which are (for samples at least) added in the CMake right here:

https://github.com/KhronosGroup/Vulkan-Hpp/blob/4266ef3040eae8101eef318756bea2549d942158/CMakeLists.txt#L526-L536

I'm not sure how you would want to handle this @asuessenbach so I didn't open a PR. We could simply check for whether _either_ samples or tests are being built, or simplify the `UniqueHandle` tests?

Continue on GitHub ↗

04 / LABELS

Labels from the report text only; not yet run

No supported category has been assigned.

Label rules and the text that matched

[]