cppHowardHinnant/date #751Not a task: already works

CMake: Allow user to opt out of install

envgap__HowardHinnant__date-751

Original GitHub issue ↗Dated source checkout ↗Opened 2022-09-26

01 / FAILURE SIGNATURE

As reported upstream

No identifying execution failure has been captured.

Not a benchmark task.

The project already builds and runs before the fix, so there is nothing to repair.

02 / ENVIRONMENT RECIPE

Base commit: 22ceabf205d8d678710a43154da5a06b701c5830
Manifest: CMakeLists.txt
Reproduce: Awaiting issue-specific recipe
Run under trace: Awaiting a meaningful runtime command

03 / ORIGINAL ISSUE TEXT

HowardHinnant/date #751 · read the original issue

Hi, thanks for the great work!



It would be very nice to make this part optional: 

https://github.com/HowardHinnant/date/blob/22ceabf205d8d678710a43154da5a06b701c5830/CMakeLists.txt#L161-L202 



For example when installing a shared library, using `date` as a private dependency, we don't want to install `date`.

A new option should be introduced `ENABLE_DATE_INSTALL` to match project convention, or `DATE_ENABLE_INSTALL` to match cmake project conventions.



Would you consider such PR? Make `ENABLE_DATE_INSTALL` default to `ON` shouldn't change any behavior, and it would give users using `date` with `add_subdirectory` to opt-out of install.



Have a nice day.

Continue on GitHub ↗

04 / LABELS

Labels from the report text only; not yet run

No supported category has been assigned.

Label rules and the text that matched

[]